Skip to content

Print the launched command in doc examples tests #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✨ New feature
📜 Docs

Description

Refactor prior to #6824

@Pierre-Sassoulas Pierre-Sassoulas added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer Maintenance Discussion or action around maintaining pylint or the dev workflow labels Jun 5, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2444509044

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.53%

Totals Coverage Status
Change from base Build 2444508483: 0.0%
Covered Lines: 16326
Relevant Lines: 17090

💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2022

🤖 Effect of this PR on checked open source code: 🤖

Effect on pandas:
The following messages are now emitted:

  1. too-many-instance-attributes:
    Too many instance attributes (31/11)
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L469
  2. no-member:
    Instance of 'Index' has no 'levels' member; maybe 'nlevels'?
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L2187
  3. no-member:
    Instance of 'Index' has no 'codes' member
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L2188

The following messages are no longer emitted:

  1. unsupported-assignment-operation:
    'mangled_aggspec' does not support item assignment
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L1529
  2. redefined-variable-type:
    Redefinition of mangled_aggspec type from str to list
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L1531
  3. too-many-instance-attributes:
    Too many instance attributes (33/11)
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L469
  4. attribute-defined-outside-init:
    Attribute 'name' defined outside init
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L9454
  5. no-member:
    Instance of 'RangeIndex' has no 'levels' member; maybe 'nlevels'?
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L2187
  6. no-member:
    Instance of 'RangeIndex' has no 'codes' member
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L2188
  7. no-member:
    Instance of 'Table' has no 'write_data' member
    https://github.com/pandas-dev/pandas/blob/main/pandas/io/pytables.py#L4355

Effect on pytest:
The following messages are now emitted:

  1. redefined-variable-type:
    Redefinition of ret type from str to _pytest.config.ExitCode
    https://github.com/pytest-dev/pytest/blob/main/src/_pytest/pytester.py#L1145
  2. redefined-variable-type:
    Redefinition of ret type from int to _pytest.config.ExitCode
    https://github.com/pytest-dev/pytest/blob/main/src/_pytest/pytester.py#L1429
  3. no-member:
    Class 'Config' has no 'ArgsSource' member
    https://github.com/pytest-dev/pytest/blob/main/src/_pytest/terminal.py#L735

The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value 'location' is unsubscriptable
    https://github.com/pytest-dev/pytest/blob/main/src/_pytest/nodes.py#L510
  2. modified-iterating-dict:
    Iterated dict 'd' is being modified inside for loop body, iterate through a copy of it instead.
    https://github.com/pytest-dev/pytest/blob/main/src/_pytest/reports.py#L515
  3. modified-iterating-dict:
    Iterated dict 'd' is being modified inside for loop body, iterate through a copy of it instead.
    https://github.com/pytest-dev/pytest/blob/main/src/_pytest/reports.py#L517
  4. consider-using-dict-items:
    Consider iterating with .items()
    https://github.com/pytest-dev/pytest/blob/main/src/_pytest/reports.py#L513

This comment was generated for commit ca6fe95

@Pierre-Sassoulas Pierre-Sassoulas merged commit 6f896b9 into pylint-dev:main Jun 6, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the print-command-in-doc-tests branch June 6, 2022 07:34
@Pierre-Sassoulas Pierre-Sassoulas removed the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label Jun 6, 2022
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.1 milestone Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants