Refactor bad option value stash in prevision of handling multiple type of messages

[Pierre-Sassoulas]

Type of Changes

	Type
✓	🔨 Refactoring

Description

Refactor prior to Refs #6824

[coveralls]

Pull Request Test Coverage Report for Build 2444496306

• 22 of 22 (100.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.0008%) to 95.53%

---

Totals
Change from base Build 2444243763:	-0.0008%
Covered Lines:	16326
Relevant Lines:	17090

---

💛 - Coveralls

[DanielNoord]

One nit!

Thanks for splitting up 👍

[Pierre-Sassoulas]

Thanks for splitting up

It was already separated by commit in the other pull request so it was easy 😄

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on pandas:
The following messages are now emitted:

1. too-many-instance-attributes:
   Too many instance attributes (31/11)
   https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L469
2. no-member:
   Instance of 'Index' has no 'levels' member; maybe 'nlevels'?
   https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L2187
3. no-member:
   Instance of 'Index' has no 'codes' member
   https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L2188

The following messages are no longer emitted:

1. unsupported-assignment-operation:
   'mangled_aggspec' does not support item assignment
   https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L1529
2. redefined-variable-type:
   Redefinition of mangled_aggspec type from str to list
   https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L1531
3. too-many-instance-attributes:
   Too many instance attributes (33/11)
   https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L469
4. attribute-defined-outside-init:
   Attribute 'name' defined outside init
   https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L9454
5. no-member:
   Instance of 'RangeIndex' has no 'levels' member; maybe 'nlevels'?
   https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L2187
6. no-member:
   Instance of 'RangeIndex' has no 'codes' member
   https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L2188
7. no-member:
   Instance of 'Table' has no 'write_data' member
   https://github.com/pandas-dev/pandas/blob/main/pandas/io/pytables.py#L4355

Effect on pytest:
The following messages are now emitted:

1. redefined-variable-type:
   Redefinition of ret type from str to _pytest.config.ExitCode
   https://github.com/pytest-dev/pytest/blob/main/src/_pytest/pytester.py#L1145
2. redefined-variable-type:
   Redefinition of ret type from int to _pytest.config.ExitCode
   https://github.com/pytest-dev/pytest/blob/main/src/_pytest/pytester.py#L1429
3. no-member:
   Class 'Config' has no 'ArgsSource' member
   https://github.com/pytest-dev/pytest/blob/main/src/_pytest/terminal.py#L735

The following messages are no longer emitted:

1. unsubscriptable-object:
   Value 'location' is unsubscriptable
   https://github.com/pytest-dev/pytest/blob/main/src/_pytest/nodes.py#L510
2. modified-iterating-dict:
   Iterated dict 'd' is being modified inside for loop body, iterate through a copy of it instead.
   https://github.com/pytest-dev/pytest/blob/main/src/_pytest/reports.py#L515
3. modified-iterating-dict:
   Iterated dict 'd' is being modified inside for loop body, iterate through a copy of it instead.
   https://github.com/pytest-dev/pytest/blob/main/src/_pytest/reports.py#L517
4. consider-using-dict-items:
   Consider iterating with .items()
   https://github.com/pytest-dev/pytest/blob/main/src/_pytest/reports.py#L513

This comment was generated for commit 2b30c7d