Skip to content

Move all public methods to _MessageStateHandler #6545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2022
Merged

Move all public methods to _MessageStateHandler #6545

merged 3 commits into from
May 8, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Blocked by #6544.

Ref #3312.

@DanielNoord DanielNoord added Blocked 🚧 Blocked by a particular issue Maintenance Discussion or action around maintaining pylint or the dev workflow labels May 8, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone May 8, 2022
@coveralls
Copy link

coveralls commented May 8, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2289825163

  • 80 of 81 (98.77%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 95.345%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/lint/message_state_handler.py 78 79 98.73%
Totals Coverage Status
Change from base Build 2289806130: 0.001%
Covered Lines: 16016
Relevant Lines: 16798
💛 - Coveralls

@DanielNoord DanielNoord mentioned this pull request May 8, 2022
Merged
2 tasks
Pierre-Sassoulas
Pierre-Sassoulas approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm not reading everything) the code got moved, PyLinter is smaller, tests still pass : LGTM ! :)

@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label May 8, 2022
@Pierre-Sassoulas Pierre-Sassoulas merged commit 8df920b into pylint-dev:main May 8, 2022
@DanielNoord DanielNoord deleted the bad-option-value-2 branch May 8, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas