Fix crash when the user ask for --version and pylintrc is malformed #3581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Pierre-Sassoulas
commented
May 4, 2020
PCManticore
approved these changes
May 5, 2020
| @@ -2,6 +2,11 @@ | |||
| # For details: https://github.com/PyCQA/pylint/blob/master/COPYING | |||
|
|
|||
| import re | |||
| import sys | |||
|
|
|||
| from astroid.__pkginfo__ import version as astroid_version | |||
There was a problem hiding this comment.
Can we grab it directly from __pkginfo__ as that is the source of truth for the version?
There was a problem hiding this comment.
Putting this version in __pgfinfo__ creates a 10+ links circular import error. I originally put it there :(
There was a problem hiding this comment.
We can't because in __pkginfo__ we're defining the dependencies for the setup.py so astroid is not installed yet. We could do it if we put the dependencies in the setup.py/pyproject.toml directly
Can't find where the version is even printed in a normal case.
Pierre-Sassoulas
force-pushed
the
fix-malformed-pylintrc-crash
branch
from
99034d0 to
2571bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix #3576 albeit in a hacky way (?) I refactored a little the version that was stored in every checker apparently. What could be the reason to do that? Also, I wonder why the BaseChecker inherit from OptionProviderMixin? Couldn't we parse the option once and give each checker it's own options so we can instantiate a checker without using sys args and optparse?
Type of Changes
Related Issue
Closes #3576