Can read setup.cfg and pyproject.toml files #3169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCManticore
approved these changes
Oct 9, 2019
| @@ -0,0 +1,27 @@ | |||
| ************************** | |||
There was a problem hiding this comment.
Nice, thanks for adding one!
pylint/__pkginfo__.py
Outdated
| "astroid>=2.3.0,<2.4", | ||
| "isort>=4.2.5,<5", | ||
| "mccabe>=0.6,<0.7", | ||
| "toml", |
There was a problem hiding this comment.
Is there a particular version that we should require here?
1 similar comment
|
awesome, thank you! |
kevinoid
added a commit
to kevinoid/pylint_runner
that referenced
this pull request
Aug 25, 2021
Pylint 2.5.0 and later support reading configuration from `pyproject.toml` or `setup.cfg` if `pylintrc` and `.pylintrc` do not exist. (pylint-dev/pylint#3169) In order to support these configuration files, use `pylint.lint.pylinter.PyLinter#read_config_file()` instead of `configparser.ConfigParser#read()` to read the pylint configuration. Signed-off-by: Kevin Locke <[email protected]>
kevinoid
added a commit
to kevinoid/pylint_runner
that referenced
this pull request
Aug 26, 2021
Pylint 2.5.0 and later support reading configuration from `pyproject.toml` or `setup.cfg` if `pylintrc` and `.pylintrc` do not exist. (pylint-dev/pylint#3169) In order to support these configuration files, use `pylint.lint.pylinter.PyLinter#read_config_file()` instead of `configparser.ConfigParser#read()` to read the pylint configuration. Signed-off-by: Kevin Locke <[email protected]>
kevinoid
added a commit
to kevinoid/pylint_runner
that referenced
this pull request
Aug 26, 2021
Pylint 2.5.0 and later support reading configuration from `pyproject.toml` or `setup.cfg` if `pylintrc` and `.pylintrc` do not exist. (pylint-dev/pylint#3169) In order to support these configuration files, use `pylint.lint.pylinter.PyLinter#read_config_file()` instead of `configparser.ConfigParser#read()` to read the pylint configuration. Signed-off-by: Kevin Locke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
Configuration can be read from a setup.cfg or pyproject.toml file. See the documentation for exactly how.
Type of Changes
Related Issue
Closes #617