Add a couple of Uninferable filters where we weren't using any

Author: PCManticore

pylint/checkers/classes.py

@@ -799,7 +799,7 @@ def _check_slots(self, node):
 
     def _check_slots_elt(self, elt):
         for infered in elt.infer():
-            if infered is astroid.YES:
+            if infered is astroid.Uninferable:
                 continue
             if (not isinstance(infered, astroid.Const) or
                     not isinstance(infered.value, six.string_types)):
@@ -1172,7 +1172,7 @@ def _check_init(self, node):
                 return
             try:
                 for klass in expr.expr.infer():
-                    if klass is astroid.YES:
+                    if klass is astroid.Uninferable:
                         continue
                     # The infered klass can be super(), which was
                     # assigned to a variable and the `__init__`

pylint/checkers/python3.py

@@ -42,8 +42,9 @@ def _check_dict_node(node):
     inferred_types = set()
     try:
         inferred = node.infer()
-        for inferred_node in inferred:
-            inferred_types.add(inferred_node)
+        if inferred is not astroid.Uninferable:
+            for inferred_node in inferred:
+                inferred_types.add(inferred_node)
     except astroid.InferenceError:
         pass
     return (not inferred_types
@@ -740,6 +741,8 @@ def visit_call(self, node):
             inferred_types = set()
             try:
                 for inferred_receiver in node.func.expr.infer():
+                    if inferred_receiver is astroid.Uninferable:
+                        continue
                     inferred_types.add(inferred_receiver)
                     if isinstance(inferred_receiver, astroid.Module):
                         self._warn_if_deprecated(node, inferred_receiver.name,

pylint/checkers/stdlib.py

@@ -193,6 +193,8 @@ def visit_call(self, node):
         """Visit a Call node."""
         try:
             for inferred in node.func.infer():
+                if inferred is astroid.Uninferable:
+                    continue
                 if inferred.root().name == OPEN_MODULE:
                     if getattr(node.func, 'name', None) in OPEN_FILES:
                         self._check_open_mode(node)

pylint/checkers/strings.py

@@ -450,7 +450,7 @@ def _check_new_format_specifiers(self, node, fields, named):
                 argument = next(argname.infer())
             except astroid.InferenceError:
                 continue
-            if not specifiers or argument is astroid.YES:
+            if not specifiers or argument is astroid.Uninferable:
                 # No need to check this key if it doesn't
                 # use attribute / item access
                 continue
@@ -461,7 +461,7 @@ def _check_new_format_specifiers(self, node, fields, named):
             previous = argument
             parsed = []
             for is_attribute, specifier in specifiers:
-                if previous is astroid.YES:
+                if previous is astroid.Uninferable:
                     break
                 parsed.append((is_attribute, specifier))
                 if is_attribute:

pylint/checkers/utils.py

@@ -820,7 +820,7 @@ def node_type(node):
     types = set()
     try:
         for var_type in node.infer():
-            if var_type == astroid.YES or is_none(var_type):
+            if var_type == astroid.Uninferable or is_none(var_type):
                 continue
             types.add(var_type)
             if len(types) > 1:

pylint/checkers/variables.py

@@ -460,7 +460,7 @@ def _check_all(self, node, not_consumed):
                 elt_name = next(elt.infer())
             except astroid.InferenceError:
                 continue
-            if elt_name is astroid.YES:
+            if elt_name is astroid.Uninferable:
                 continue
             if not elt_name.parent:
                 continue
@@ -1222,7 +1222,7 @@ def _check_module_attrs(self, node, module, module_names):
                 break
             try:
                 module = next(module.getattr(name)[0].infer())
-                if module is astroid.YES:
+                if module is astroid.Uninferable:
                     return None
             except astroid.NotFoundError:
                 if module.name in self._ignored_modules: