Revert #1984 to see what goes on in primers

Author: Pierre-Sassoulas

pylint/checkers/refactoring/refactoring_checker.py

@@ -546,23 +546,6 @@ def _check_simplifiable_if(self, node):
         elif isinstance(first_branch, nodes.Assign):
             if not isinstance(else_branch, nodes.Assign):
                 return
-
-            # Check if we assign to the same value
-            first_branch_targets = [
-                target.name
-                for target in first_branch.targets
-                if isinstance(target, nodes.AssignName)
-            ]
-            else_branch_targets = [
-                target.name
-                for target in else_branch.targets
-                if isinstance(target, nodes.AssignName)
-            ]
-            if not first_branch_targets or not else_branch_targets:
-                return
-            if sorted(first_branch_targets) != sorted(else_branch_targets):
-                return
-
             first_branch_is_bool = self._is_bool_const(first_branch)
             else_branch_is_bool = self._is_bool_const(else_branch)
             reduced_to = "'var = bool(test)'"

tests/functional/s/simplifiable/simplifiable_if_statement.py

@@ -128,7 +128,7 @@ def test_not_simplifiable_9():
     fourth = False
     fifth = False
 
-    if first and second in third:
+    if first and second in third:  # [simplifiable-if-statement]
         fourth = True
     else:
         fifth = True
@@ -139,7 +139,7 @@ def test_not_simplifiable_10():
     # Subscripts are not considered
     object_type = 'read'
     filter_kwargs = {}
-    if object_type == 'read':
+    if object_type == 'read':  # [simplifiable-if-statement]
         filter_kwargs['a'] = True
     else:
         filter_kwargs['b'] = True