Merge the empty-string extensions to 'implicit_booleaness_checker'

Author: Pierre-Sassoulas

doc/data/messages/c/compare-to-empty-string/bad.py

@@ -0,0 +1,6 @@
+def important_string_manipulation(x: str, y: str) -> None:
+    if x == "":  # [use-implicit-booleaness-not-comparison-to-string]
+        print("x is an empty string")
+
+    if y != "":  # [use-implicit-booleaness-not-comparison-to-string]
+        print("y is not an empty string")

doc/data/messages/c/compare-to-empty-string/good.py

@@ -0,0 +1,3 @@
+Following this check blindly in weakly typed code base can create hard to debug issues. If the value
+can be something else that is falsey but not a string (for example ``None``, or ``0``), the code will
+not be equivalent.

doc/data/messages/c/compare-to-empty-string/pylintrc

@@ -0,0 +1,6 @@
+def important_string_manipulation(x: str, y: str) -> None:
+    if not x:
+        print("x is an empty string")
+
+    if y:
+        print("y is not an empty string")

doc/data/messages/u/use-implicit-booleaness-not-comparison-to-string/bad.py

@@ -0,0 +1,2 @@
+[main]
+enable=use-implicit-booleaness-not-comparison-to-string

doc/data/messages/u/use-implicit-booleaness-not-comparison-to-string/details.rst

@@ -19,7 +19,6 @@ Pylint provides the following optional plugins:
 - :ref:`pylint.extensions.docstyle`
 - :ref:`pylint.extensions.dunder`
 - :ref:`pylint.extensions.empty_comment`
-- :ref:`pylint.extensions.emptystring`
 - :ref:`pylint.extensions.eq_without_hash`
 - :ref:`pylint.extensions.for_any_all`
 - :ref:`pylint.extensions.magic_value`
@@ -87,20 +86,6 @@ Code Style checker Messages
   to. This can be changed to be an augmented assign. Disabled by default!
 
 
-.. _pylint.extensions.emptystring:
-
-Compare-To-Empty-String checker
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-This checker is provided by ``pylint.extensions.emptystring``.
-Verbatim name of the checker is ``compare-to-empty-string``.
-
-Compare-To-Empty-String checker Messages
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-:compare-to-empty-string (C1901): *"%s" can be simplified to "%s" as an empty string is falsey*
-  Used when Pylint detects comparison to an empty string constant.
-
-
 .. _pylint.extensions.comparison_placement:
 
 Comparison-Placement checker

doc/data/messages/u/use-implicit-booleaness-not-comparison-to-string/good.py

@@ -893,8 +893,10 @@ Refactoring checker Messages
   Emitted when a single "return" or "return None" statement is found at the end
   of function or method definition. This statement can safely be removed
   because Python will implicitly return None
-:use-implicit-booleaness-not-comparison-to-zero (C1804): *"%s" can be simplified to "%s" as 0 is falsey*
+:use-implicit-booleaness-not-comparison-to-zero (C1805): *"%s" can be simplified to "%s" as 0 is falsey*
   Used when Pylint detects comparison to a 0 constant.
+:use-implicit-booleaness-not-comparison-to-string (C1804): *"%s" can be simplified to "%s" as an empty string is falsey*
+  Used when Pylint detects comparison to an empty string constant.
 :use-implicit-booleaness-not-comparison (C1803): *'%s' can be simplified to '%s' as an empty %s is falsey*
   Used when Pylint detects that collection literal comparison is being used to
   check for emptiness; Use implicit booleaness instead of a collection classes;

doc/data/messages/u/use-implicit-booleaness-not-comparison-to-string/pylintrc

@@ -233,7 +233,7 @@ Standard Checkers
 
    confidence = ["HIGH", "CONTROL_FLOW", "INFERENCE", "INFERENCE_FAILURE", "UNDEFINED"]
 
-   disable = ["raw-checker-failed", "bad-inline-option", "locally-disabled", "file-ignored", "suppressed-message", "useless-suppression", "deprecated-pragma", "use-implicit-booleaness-not-comparison-to-zero", "use-symbolic-message-instead", "consider-using-augmented-assign"]
+   disable = ["raw-checker-failed", "bad-inline-option", "locally-disabled", "file-ignored", "suppressed-message", "useless-suppression", "deprecated-pragma", "use-implicit-booleaness-not-comparison-to-string", "use-implicit-booleaness-not-comparison-to-zero", "use-symbolic-message-instead", "consider-using-augmented-assign"]
 
    enable = []