Move typechecking imports under TYPE_CHECKING flag

Author: nickdrozd

pylint/checkers/bad_chained_comparison.py

@@ -6,12 +6,12 @@
 
 from typing import TYPE_CHECKING
 
-from astroid import nodes
-
 from pylint.checkers import BaseChecker
 from pylint.interfaces import HIGH
 
 if TYPE_CHECKING:
+    from astroid import nodes
+
     from pylint.lint import PyLinter
 
 COMPARISON_OP = frozenset(("<", "<=", ">", ">=", "!=", "=="))

pylint/checkers/base/basic_checker.py

@@ -8,20 +8,22 @@
 
 import collections
 import itertools
-from collections.abc import Iterator
 from typing import TYPE_CHECKING, Literal, cast
 
 import astroid
 from astroid import nodes, objects, util
 
 from pylint import utils as lint_utils
 from pylint.checkers import BaseChecker, utils
-from pylint.interfaces import HIGH, INFERENCE, Confidence
+from pylint.interfaces import HIGH, INFERENCE
 from pylint.reporters.ureports import nodes as reporter_nodes
-from pylint.utils import LinterStats
 
 if TYPE_CHECKING:
+    from collections.abc import Iterator
+
+    from pylint.interfaces import Confidence
     from pylint.lint.pylinter import PyLinter
+    from pylint.utils import LinterStats
 
 
 class _BasicChecker(BaseChecker):

pylint/checkers/base/basic_error_checker.py

@@ -7,16 +7,20 @@
 from __future__ import annotations
 
 import itertools
+from typing import TYPE_CHECKING
 
 import astroid
 from astroid import nodes
-from astroid.typing import InferenceResult
 
 from pylint.checkers import utils
 from pylint.checkers.base.basic_checker import _BasicChecker
 from pylint.checkers.utils import infer_all
 from pylint.interfaces import HIGH
 
+if TYPE_CHECKING:
+    from astroid.typing import InferenceResult
+
+
 ABC_METACLASSES = {"_py_abc.ABCMeta", "abc.ABCMeta"}  # Python 3.7+,
 # List of methods which can be redefined
 REDEFINABLE_METHODS = frozenset(("__module__",))

pylint/checkers/base/docstring_checker.py

@@ -7,7 +7,8 @@
 from __future__ import annotations
 
 import re
-from typing import Literal
+from typing import TYPE_CHECKING
+
 
 import astroid
 from astroid import nodes
@@ -21,6 +22,10 @@
     is_property_setter,
 )
 
+if TYPE_CHECKING:
+    from typing import Literal
+
+
 # do not require a doc string on private/system methods
 NO_REQUIRED_DOC_RGX = re.compile("^_")
 

pylint/checkers/base/name_checker/checker.py

@@ -6,14 +6,11 @@
 
 from __future__ import annotations
 
-import argparse
 import collections
 import itertools
 import re
 import sys
-from collections.abc import Iterable
 from enum import Enum, auto
-from re import Pattern
 from typing import TYPE_CHECKING
 
 import astroid
@@ -29,10 +26,14 @@
     _create_naming_options,
 )
 from pylint.checkers.utils import is_property_deleter, is_property_setter
-from pylint.typing import Options
 
 if TYPE_CHECKING:
+    import argparse
+    from collections.abc import Iterable
+    from re import Pattern
+
     from pylint.lint.pylinter import PyLinter
+    from pylint.typing import Options
 
 _BadNamesTuple = tuple[nodes.NodeNG, str, str, interfaces.Confidence]
 

pylint/checkers/base/name_checker/naming_style.py

@@ -5,10 +5,14 @@
 from __future__ import annotations
 
 import re
-from re import Pattern
+from typing import TYPE_CHECKING
 
 from pylint import constants
-from pylint.typing import OptionDict, Options
+
+if TYPE_CHECKING:
+    from re import Pattern
+
+    from pylint.typing import OptionDict, Options
 
 
 class NamingStyle:

pylint/checkers/base_checker.py

@@ -6,29 +6,31 @@
 
 import abc
 import functools
-from collections.abc import Iterable, Sequence
 from inspect import cleandoc
-from tokenize import TokenInfo
-from typing import TYPE_CHECKING, Any
-
-from astroid import nodes
+from typing import TYPE_CHECKING
 
 from pylint.config.arguments_provider import _ArgumentsProvider
 from pylint.constants import _MSG_ORDER, MAIN_CHECKER_NAME, WarningScope
 from pylint.exceptions import InvalidMessageError
-from pylint.interfaces import Confidence
 from pylint.message.message_definition import MessageDefinition
-from pylint.typing import (
-    ExtraMessageOptions,
-    MessageDefinitionTuple,
-    OptionDict,
-    Options,
-    ReportsCallable,
-)
+from pylint.typing import ExtraMessageOptions
 from pylint.utils import get_rst_section, get_rst_title
 
 if TYPE_CHECKING:
+    from collections.abc import Iterable, Sequence
+    from tokenize import TokenInfo
+    from typing import Any
+
+    from astroid import nodes
+
     from pylint.lint import PyLinter
+    from pylint.interfaces import Confidence
+    from pylint.typing import (
+        MessageDefinitionTuple,
+        OptionDict,
+        Options,
+        ReportsCallable,
+    )
 
 
 @functools.total_ordering

pylint/checkers/classes/class_checker.py

@@ -7,16 +7,12 @@
 from __future__ import annotations
 
 from collections import defaultdict
-from collections.abc import Callable, Sequence
 from functools import cached_property
 from itertools import chain, zip_longest
-from re import Pattern
-from typing import TYPE_CHECKING, Any, NamedTuple, Union
+from typing import TYPE_CHECKING, NamedTuple
 
 import astroid
-from astroid import bases, nodes, util
-from astroid.nodes import LocalsDictNodeNG
-from astroid.typing import SuccessfulInferenceResult
+from astroid import nodes, util
 
 from pylint.checkers import BaseChecker, utils
 from pylint.checkers.utils import (
@@ -40,13 +36,21 @@
     uninferable_final_decorators,
 )
 from pylint.interfaces import HIGH, INFERENCE
-from pylint.typing import MessageDefinitionTuple
 
 if TYPE_CHECKING:
+    from collections.abc import Callable, Sequence
+    from re import Pattern
+    from typing import Any, Union
+
+    from astroid import bases
+    from astroid.nodes import LocalsDictNodeNG
+    from astroid.typing import SuccessfulInferenceResult
+
     from pylint.lint.pylinter import PyLinter
+    from pylint.typing import MessageDefinitionTuple
 
+    _AccessNodes = Union[nodes.Attribute, nodes.AssignAttr]
 
-_AccessNodes = Union[nodes.Attribute, nodes.AssignAttr]
 
 INVALID_BASE_CLASSES = {"bool", "range", "slice", "memoryview"}
 ALLOWED_PROPERTIES = {"bultins.property", "functools.cached_property"}

pylint/checkers/classes/special_methods_checker.py

@@ -6,12 +6,10 @@
 
 from __future__ import annotations
 
-from collections.abc import Callable
+from typing import TYPE_CHECKING
 
 import astroid
 from astroid import bases, nodes, util
-from astroid.context import InferenceContext
-from astroid.typing import InferenceResult
 
 from pylint.checkers import BaseChecker
 from pylint.checkers.utils import (
@@ -22,7 +20,15 @@
     only_required_for_messages,
     safe_infer,
 )
-from pylint.lint.pylinter import PyLinter
+
+if TYPE_CHECKING:
+    from collections.abc import Callable
+
+    from astroid.context import InferenceContext
+    from astroid.typing import InferenceResult
+
+    from pylint.lint.pylinter import PyLinter
+
 
 NEXT_METHOD = "__next__"
 

pylint/checkers/deprecated.py

@@ -6,8 +6,8 @@
 
 from __future__ import annotations
 
-from collections.abc import Container, Iterable
 from itertools import chain
+from typing import TYPE_CHECKING
 
 import astroid
 from astroid import nodes
@@ -17,7 +17,12 @@
 from pylint.checkers.base_checker import BaseChecker
 from pylint.checkers.utils import get_import_name, infer_all, safe_infer
 from pylint.interfaces import INFERENCE
-from pylint.typing import MessageDefinitionTuple
+
+if TYPE_CHECKING:
+    from collections.abc import Container, Iterable
+
+    from pylint.typing import MessageDefinitionTuple
+
 
 ACCEPTABLE_NODES = (
     astroid.BoundMethod,