BUG: Don't transpose variables of one dimension #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -647,6 +647,9 @@ def transpose(self, *dims): | |||
| """ | |||
| if len(dims) == 0: | |||
| dims = self.dims[::-1] | |||
| # no need to transpose if only one dimension | |||
| if len(dims) == 1: | |||
| return self | |||
There was a problem hiding this comment.
It's OK to keep the data the same, but we shouldn't return the same Variable object. I would use self.copy(deep=False) instead. Also, let's check after we verify that dims is valid (e.g., move the conditional one line below). Probably a little safer to use if self.ndim < 2 as the check instead, too.
|
Great, @shoyer, updated |
|
Failing on this: pandas-dev/pandas#12235, will push again when resolved |
|
@shoyer green |
shoyer
added a commit
that referenced
this pull request
Feb 9, 2016
…pose BUG: Don't transpose variables of one dimension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #745
A bit of a 'convenient hack'. Let me know if you think there's a better way to do this