Don't quote strings in FacetGrid titles #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Do you know what's going on with the 3.4 tests? |
`model = foo` looks better than `model = 'foo'` or `model = u'foo'`. This is also consistent with what Seaborn does.
shoyer
force-pushed
the
facetgrid-titles-no-quote
branch
from
fdd86f5 to
ad35bd2
Compare
|
Yep, failing tests should be fixed by this change: #569 Just did a rebase, tests should pass now. |
shoyer
added a commit
that referenced
this pull request
Sep 11, 2015
Don't quote strings in FacetGrid titles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
model = foolooks better thanmodel = 'foo'ormodel = u'foo'.This is also consistent with what Seaborn does.