Skip to content

Amend documentation to clean up temporary files/directories in examples #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2019
Merged

Amend documentation to clean up temporary files/directories in examples #3270

merged 2 commits into from
Aug 28, 2019

Conversation

gwgundersen
Copy link
Contributor

@gwgundersen gwgundersen commented Aug 27, 2019 •
edited
Loading

  • Closes Building the docs creates temporary files #3227.
  • No CI tests added, but I ran make clean and make html to confirm the temporary files are no longer permanently created. I also confirmed the :suppress: blocks weren't showing up in the built HTML.
  • No need to pass black . && mypy . && flake8.
  • Fully documented in whats-new.rst.

@max-sixty max-sixty self-requested a review August 27, 2019 23:21
max-sixty
max-sixty approved these changes Aug 27, 2019
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @gwgundersen

@shoyer shoyer merged commit 8969b5a into pydata:master Aug 28, 2019
@shoyer
Copy link
Member

shoyer commented Aug 28, 2019

thanks!

@stanwest stanwest mentioned this pull request Feb 4, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building the docs creates temporary files
3 participants
@gwgundersen @shoyer @max-sixty