Support dot with older dask #2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
approved these changes
May 31, 2018
xarray/tests/test_computation.py
Outdated
| @@ -784,6 +781,10 @@ def test_dot(use_dask): | |||
| assert (actual.data == np.einsum('ij,ijk->k', a, b)).all() | |||
| assert isinstance(actual.variable.data, type(da_a.variable.data)) | |||
|
|
|||
| import dask | |||
There was a problem hiding this comment.
This needs to be guarded behind use_dask. Currently the tests without dask installed are failing here on Travis-CI.
doc/whats-new.rst
Outdated
| @@ -37,6 +37,10 @@ Documentation | |||
| Enhancements | |||
| ~~~~~~~~~~~~ | |||
|
|
|||
| - `:py:meth:`~DataArray.dot` and :py:func:`~dot` are partly supported with older | |||
| dask<01.7.4. (related to :issue:`2203`) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #2203, I think it is better if
xr.DataArray.dot()is working even with older dask, at least in the simpler case (as this is a very primary operation).The cost is a slight complication of the code.
Any comments are welcome.