fixes for warnings related to unit tests and nan comparisons

xarray/core/dataarray.py

@@ -1571,7 +1571,9 @@ def __array_wrap__(self, obj, context=None):
     def _unary_op(f):
         @functools.wraps(f)
         def func(self, *args, **kwargs):
-            return self.__array_wrap__(f(self.variable.data, *args, **kwargs))
+            with np.errstate(all='ignore'):
+                return self.__array_wrap__(f(self.variable.data, *args,
+                                             **kwargs))
 
         return func
 
@@ -1588,9 +1590,10 @@ def func(self, other):
             other_variable = getattr(other, 'variable', other)
             other_coords = getattr(other, 'coords', None)
 
-            variable = (f(self.variable, other_variable)
-                        if not reflexive
-                        else f(other_variable, self.variable))
+            with np.errstate(all='ignore'):
+                variable = (f(self.variable, other_variable)
+                            if not reflexive
+                            else f(other_variable, self.variable))
             coords = self.coords._merge_raw(other_coords)
             name = self._result_name(other)
 
@@ -1612,7 +1615,8 @@ def func(self, other):
             other_coords = getattr(other, 'coords', None)
             other_variable = getattr(other, 'variable', other)
             with self.coords._merge_inplace(other_coords):
-                f(self.variable, other_variable)
+                with np.errstate(all='ignore'):
+                    f(self.variable, other_variable)
             return self
 
         return func

xarray/core/pycompat.py

@@ -25,6 +25,7 @@ def itervalues(d):
     from functools import reduce
     import builtins
     from urllib.request import urlretrieve
+    from inspect import getfullargspec as getargspec
 else:  # pragma: no cover
     # Python 2
     basestring = basestring  # noqa
@@ -43,7 +44,7 @@ def itervalues(d):
     reduce = reduce
     import __builtin__ as builtins
     from urllib import urlretrieve
-
+    from inspect import getargspec
 try:
     from cyordereddict import OrderedDict
 except ImportError:  # pragma: no cover

xarray/core/variable.py

@@ -1354,7 +1354,8 @@ def __array_wrap__(self, obj, context=None):
     def _unary_op(f):
         @functools.wraps(f)
         def func(self, *args, **kwargs):
-            return self.__array_wrap__(f(self.data, *args, **kwargs))
+            with np.errstate(all='ignore'):
+                return self.__array_wrap__(f(self.data, *args, **kwargs))
         return func
 
     @staticmethod
@@ -1364,9 +1365,10 @@ def func(self, other):
             if isinstance(other, (xr.DataArray, xr.Dataset)):
                 return NotImplemented
             self_data, other_data, dims = _broadcast_compat_data(self, other)
-            new_data = (f(self_data, other_data)
-                        if not reflexive
-                        else f(other_data, self_data))
+            with np.errstate(all='ignore'):
+                new_data = (f(self_data, other_data)
+                            if not reflexive
+                            else f(other_data, self_data))
             result = Variable(dims, new_data)
             return result
         return func
@@ -1381,7 +1383,8 @@ def func(self, other):
             if dims != self.dims:
                 raise ValueError('dimensions cannot change for in-place '
                                  'operations')
-            self.values = f(self_data, other_data)
+            with np.errstate(all='ignore'):
+                self.values = f(self_data, other_data)
             return self
         return func
 

xarray/plot/facetgrid.py

@@ -2,13 +2,13 @@
 from __future__ import division
 from __future__ import print_function
 
-import inspect
 import warnings
 import itertools
 import functools
 
 import numpy as np
 
+from ..core.pycompat import getargspec
 from ..core.formatting import format_item
 from .utils import _determine_cmap_params, _infer_xy_labels
 
@@ -227,7 +227,7 @@ def map_dataarray(self, func, x, y, **kwargs):
                        'filled': func.__name__ != 'contour',
                        }
 
-        cmap_args = inspect.getargspec(_determine_cmap_params).args
+        cmap_args = getargspec(_determine_cmap_params).args
         cmap_kwargs.update((a, kwargs[a]) for a in cmap_args if a in kwargs)
 
         cmap_params = _determine_cmap_params(**cmap_kwargs)

xarray/tests/test_accessors.py

@@ -6,7 +6,7 @@
 import numpy as np
 import pandas as pd
 
-from . import TestCase, requires_dask
+from . import TestCase, requires_dask, raises_regex
 
 
 class TestDatetimeAccessor(TestCase):
@@ -45,7 +45,7 @@ def test_not_datetime_type(self):
         nontime_data = self.data.copy()
         int_data = np.arange(len(self.data.time)).astype('int8')
         nontime_data['time'].values = int_data
-        with self.assertRaisesRegexp(TypeError, 'dt'):
+        with raises_regex(TypeError, 'dt'):
             nontime_data.time.dt
 
     @requires_dask
@@ -93,4 +93,4 @@ def test_seasons(self):
                    "SON", "SON", "SON", "DJF"]
         seasons = xr.DataArray(seasons)
 
-        self.assertArrayEqual(seasons.values, dates.dt.season.values)
+        self.assertArrayEqual(seasons.values, dates.dt.season.values)