Skip to content

Deprecate Dataset.T as an alias for Dataset.transpose() #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2017

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Oct 21, 2017

  • Closes Remove the Dataset.T property? #1232
  • Tests added / passed
  • Passes git diff upstream/master | flake8 --diff
  • Fully documented, including whats-new.rst for all changes and api.rst for new API

@rabernat
Copy link
Contributor

This is great. I hit this annoyance all the time with any dataset from the IRI data library:
http://iridl.ldeo.columbia.edu/

The time dimension is always called T.

@shoyer shoyer merged commit 8f5e932 into pydata:master Oct 22, 2017
@shoyer shoyer deleted the deprecated-Dataset-T branch October 22, 2017 01:04
@brian-rose
Copy link
Contributor

I'm happy to see this too!
I raised this way back in #687, but at the time the consensus was that .T notation was preferred for transposing because of consistency with numpy.
I've been using .rename on all variables called T ever since -- usually temperature in my use cases.

@max-sixty
Copy link
Collaborator

max-sixty commented Nov 2, 2017

Good to go back and read my own comments:

Removing .T would break so much existing code, I don't think that's going to get much support. It's also consistent with numpy.

Good case to reflect on whether we're looking at the idea rather than the person's experience; whether we're using the right cognitive shortcuts ('[not] going to get much support'); etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants