New properties Dataset.sizes and DataArray.sizes
#1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
reviewed
Nov 3, 2016
| numpy.squeeze | ||
| """ | ||
| if dim is None: | ||
| dim = [d for d, s in self.sizes.item() if s == 1] |
max-sixty
reviewed
Nov 3, 2016
| @@ -110,6 +111,31 @@ def __setitem__(self, key, value): | |||
| self.data_array[pos_indexers] = value | |||
|
|
|||
|
|
|||
| class DataArraySizes(collections.Mapping, formatting.ReprMixin): | |||
There was a problem hiding this comment.
Does this need a separate class that holds the array?
Could it be a dict of dim-name to dim-size?
There was a problem hiding this comment.
Probably not -- could just generate an object on the fly, e.g., Frozen(OrderedDict(zip(self.dims, self.shape))). Let me do a quick micro benchmark to see if that has appreciably different performance.
This allows for consistent access to dimension lengths on ``Dataset`` and ``DataArray`` xref pydata#921 (doesn't resolve it 100%, but should help significantly)
|
Updated to remove the custom class. It makes accessing a single dimension length from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for consistent access to dimension lengths on
DatasetandDataArrayxref #921 (doesn't resolve it 100%, but should help significantly)