COMPAT: Make is_number import backwards-compat #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
May 7, 2017
pandas_datareader/edgar.py
Outdated
|
|
||
| from pandas_datareader.base import _BaseReader | ||
| from pandas_datareader.compat import BytesIO | ||
| from pandas_datareader._utils import RemoteDataError | ||
|
|
||
| if LooseVersion(pd.__version__) <= '0.19.2': |
There was a problem hiding this comment.
would put this in pandas_datareader/compat/__init__.py
if LooseVersion(.....):
from pandas.core import common as pdapi
else:
from pandas.api import types as pdapi
then you can
from pandas_datareader.compat import pdapi
There was a problem hiding this comment.
That works too (actually didn't see that).
There was a problem hiding this comment.
if directly import is_number in compat is ok too. this then isolates all version specific things there.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory.
xref #304.