-
Notifications
You must be signed in to change notification settings - Fork 292
implementing validate_strings
#883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #883 will improve performances by 34.14%Comparing Summary
Benchmarks breakdown
|
fe88da1
to
0091c65
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
==========================================
- Coverage 93.78% 93.16% -0.63%
==========================================
Files 105 106 +1
Lines 15539 15744 +205
Branches 25 25
==========================================
+ Hits 14574 14668 +94
- Misses 959 1070 +111
Partials 6 6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
02106d5
to
a9828c8
Compare
e2a0e38
to
a89eddf
Compare
validate_string
730d631
to
b69be8f
Compare
validate_string
validate_strings
b69be8f
to
72f979a
Compare
please review |
Complex: do something clever withdh - resolved in make error "duplicate" cheaper #950InputValue
and/oras_error_value
to either makeerror.into_owned()
cheaper or reduce its usedataclass
as well asmodel
andtyped_dict
String
implementation ofInput
back intoinput_json
as it's ownly used by JSON keys.validate_strings
Selected Reviewer: @dmontagu