Skip to content

try testing and building for 3.12 #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 3, 2023
Merged

try testing and building for 3.12 #629

merged 8 commits into from
Jul 3, 2023

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented May 24, 2023

@samuelcolvin samuelcolvin added the Full Build cause CI to do a full build label May 24, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented May 24, 2023

CodSpeed Performance Report

Merging #629 will not alter performances

Comparing test-build-3.12 (475162a) with main (d45cc57)

Summary

✅ 125 untouched benchmarks

@art049
Copy link
Contributor

art049 commented May 25, 2023

@samuelcolvin thanks for reporting this, we're working on a fix.

@art049
Copy link
Contributor

art049 commented May 25, 2023

@samuelcolvin It's fixed. New comments are working as expected. We will update old invalid messages ASAP.

@samuelcolvin
Copy link
Member Author

thanks so much.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2023

Codecov Report

Merging #629 (475162a) into main (d45cc57) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          99       99           
  Lines       13911    13911           
  Branches       25       25           
=======================================
  Hits        13026    13026           
  Misses        879      879           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45cc57...475162a. Read the comment docs.

@samuelcolvin
Copy link
Member Author

waiting for python/cpython#105042

@samuelcolvin samuelcolvin marked this pull request as ready for review July 3, 2023 12:23
@samuelcolvin samuelcolvin merged commit 7da7496 into main Jul 3, 2023
@samuelcolvin samuelcolvin deleted the test-build-3.12 branch July 3, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Build cause CI to do a full build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants