-
Notifications
You must be signed in to change notification settings - Fork 290
Implement datetime timezone constraints #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement datetime timezone constraints #343
Conversation
CodSpeed Performance ReportMerging #343 Summary
|
Converted to draft, looking at the test failures. |
05781c1
to
2429637
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 96.34% 97.13% +0.78%
==========================================
Files 58 58
Lines 6953 6978 +25
Branches 47 47
==========================================
+ Hits 6699 6778 +79
+ Misses 252 200 -52
+ Partials 2 0 -2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@samuelcolvin Any idea what's going on with the wasm build? Do we need to specify somewhere to also build the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks to me like the wasm failures are a problem with hypothesis trying to import tzinfo, not relelated to the tests here.
You could be able to check this by adding conventional tests for this behaviour, then mark the hypothesis tests as skipped on wasm
overall, this looks great - doesn't look like that much to change. |
2429637
to
8c76666
Compare
This implements support for constraining datetime objects based on them having or not having timezone info. The aware kind constrains to objects that have timezone info, and symmetrically, the naive kind constrains to objects that do not have timezone info.
8c76666
to
9dccdea
Compare
I simplified both tests and merged the two types as suggested. Overall, even though this is a very small change, very enjoyable to work with Rust I must say! 👍 |
This is great, thanks so much. Pleased you enjoyed it, I'd love you to contribute more if you have the time. |
Alright, so I got something together that is seemingly working. Please let me know if you think something should be done differently, or structured in another way.
This implements support for constraining datetime objects based on them having or not having timezone info. The aware kind constrains to objects that have timezone info, and symmetrically, the naive kind constrains to objects that do not have timezone info.
Closes #266.