update to PyO3 0.22, add 3.13 support #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1340 will not alter performanceComparing Summary
|
Comment on lines
-477
to
-481
| let fields = schema | ||
| .get_as_req::<&PyList>(intern!(py, "fields"))? | ||
| .iter() | ||
| .map(|s| Ok(s.downcast::<PyString>()?.into_py(py))) | ||
| .collect::<PyResult<Vec<_>>>()?; |
There was a problem hiding this comment.
Why don't we need this anymore?
There was a problem hiding this comment.
Type inference is able to work out that we want fields to be Vec<Py<PyString>>, so best to let PyO3 decide the most efficient way to achieve that.
This code was flagged to me because &PyList is now removed as a type (we always wrap it as Py<PyList> or Bound<'_, PyList> now), so I simplified :)
sydney-runkle
suggested changes
Jun 24, 2024
davidhewitt
force-pushed
the
dh/pyo3-0.22
branch
from
d5e372a to
f3a5c1d
Compare
davidhewitt
force-pushed
the
dh/pyo3-0.22
branch
from
f3a5c1d to
bfa816c
Compare
davidhewitt
force-pushed
the
dh/pyo3-0.22
branch
from
0da9d55 to
b10515e
Compare
sydney-runkle
approved these changes
Jun 24, 2024
|
Ah also we can update |
davidhewitt
changed the title
| @@ -436,27 +438,33 @@ jobs: | |||
| # macos; | |||
| # all versions x86_64 | |||
| # arm pypy and older pythons which can't be run on the arm hardware for PGO | |||
| # | |||
| # FIXME https://github.com/PyO3/maturin-action/issues/275 | |||
| # cffi prevents `maturin-action` working on macOS 3.13 for now for the optimized build | |||
There was a problem hiding this comment.
cffi is close, they have a pre release out with support :)
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Updates to PyO3 0.22
Related issue number
Closes #1175
Closes #1292
Checklist
pydantic-core(except for expected changes)