Skip to content

Set env: VERBOSE: 1 as suggested by @henryiii #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Dec 13, 2022

Description

Improve on #4398 in two ways:

  1. Set env: VERBOSE: 1 in ci.yml as suggested by @henryiii.
  2. Also apply this to all other .yml files using cmake.

To make it easy to see what the net changes are, compared to the state before #4398:

  • commit 5136cb5 rolls back #4398.
  • commit 6abc642 brings back the functional equivalent of #4398, but instead of adding many -DCMAKE_VERBOSE_MAKEFILE=ON it removes a few.
  • commit b939e13 applies the env: VERBOSE: 1 to all other .yml files using cmake.

The CI logs were inspected manually to verify that this PR is working as intended.

Suggested changelog entry:

@rwgk rwgk marked this pull request as ready for review December 14, 2022 23:17
@rwgk rwgk requested a review from henryiii as a code owner December 14, 2022 23:17
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like increasing the verbosity - while it does help occasionally for certain things, most of the time it just adds a ton of irrelevant logging lines making checking the output for compiler errors and warnings harder to see. 95% of the time you aren't checking to see what's passed to the compiler. But this change over what's already been merged is a clear positive, IMO.

@henryiii henryiii merged commit ece1206 into pybind:master Dec 15, 2022
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Dec 15, 2022
@rwgk
Copy link
Collaborator Author

rwgk commented Dec 16, 2022

95% of the time you aren't checking to see what's passed to the compiler.

I would put that number even higher >99%

But for those <1%, I often found it impractical to get the insights I wanted and resorted to guessing. — Impractical: e.g. looking back in the logs from last week, 10 or so commits ago: ouch, the information isn't there. It can be a real ordeal to backtrack to run the CI again for that state.

What guides my thinking here:

  • Filtering is easy and conclusive.
  • Guessing is hard and inconclusive.

@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Dec 16, 2022
@rwgk rwgk deleted the env_VERBOSE branch December 16, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants