Added a test to detect invalid RTTI caching #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current inheritance testing isn't sufficient to detect a cache failure; the test added here breaks PR pybind#390, which caches the run-time-determined return type the first time a function is called, then reuses that cached type even though the run-time type could be different for a future call.
|
LGTM |
jagerman
added a commit
to jagerman/pybind11
that referenced
this pull request
Sep 12, 2016
Each time a function is called, we currently do a type lookup in registered_types_cpp to figure out the python type info associated with the return value. This lookup isn't free, particularly for often-called functions, but will usually yield an identical result each time the function is called. This commit adds a per-return-type cache into the return type lookup for generic types (i.e. those inheriting from type_caster_generic) to avoid the hash lookup. The cache is invalidated whenever the runtime type changes (to avoid the problem PR pybind#409 tests for).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current inheritance testing isn't sufficient to detect a cache failure; the test added here breaks PR #390, which caches the run-time-determined return type the first time a function is called, then reuses that cached type even though the run-time type could be different for a future call.