[smart_holder] Simple experiment related to PR #4022 #4028

rwgk · 2022-06-24T11:23:56Z

Description

Scratch PR, just to probe quickly what compilers support __builtin_FILE() & __builtin_LINE().

The only change on top of PR #4022 is 92021f3.

Suggested changelog entry:

…tructor.

…fers

…864, which has more changes on top.

…ion_unit_local) {`

…TER_SOURCE_FILE_LINE, baked into PYBIND11_TYPE_CASTER macro.

…esolves "unused" warning when compiling test_custom_type_casters.cpp

…ails to link. Trying GitHub Actions anyway to see if there are any platforms that support https://en.cppreference.com/w/cpp/language/tu_local before C++20. Note that Debian clang 13 C++17 works locally.

…_guard_1,2.cpp

…idy). See also: https://stackoverflow.com/questions/39995573/when-can-i-use-explicit-operator-bool-without-a-cast

…lt).

…ation_detected_counter()

… not fail).

…_caster_odr_violation_detected_count() == 0

rwgk · 2022-06-24T12:03:04Z

Good news for PR #4022: the only compiler that supports TU-local but not __builtin_FILE() & __builtin_LINE() is MSVC 2017 (Appveyor, 15.9.21).

rwgk added 30 commits June 12, 2022 11:24

Insert type_caster_odr_guard<> (an empty struct to start with).

aacf679

Add odr_guard_registry() used in type_caster_odr_guard() default cons…

2b604e0

…tructor.

Add minimal_real_caster (from PR pybind#3862) to test_async, test_buf…

3657253

…fers

VERY MESSY SNAPSHOT of WIP, this was the starting point for cl/454658…

48e3e5c

…864, which has more changes on top.

Restore original test_async, test_buffers from current smart_holder HEAD

5c8183e

Copy from cl/454991845 snapshot Jun 14, 5:08 PM

3a6b99a

Cleanup of tests. Systematically insert `if (make_caster<T>::translat…

526d3e3

…ion_unit_local) {`

Small simplification of odr_guard_impl()

d85a9e9

WIP

e126f3d

Add PYBIND11_SOURCE_FILE_LINE macro.

3656270

Replace PYBIND11_TYPE_CASTER_UNIQUE_IDENTIFIER with PYBIND11_TYPE_CAS…

c571fe5

…TER_SOURCE_FILE_LINE, baked into PYBIND11_TYPE_CASTER macro.

Add more PYBIND11_DETAIL_TYPE_CASTER_ACCESS_TRANSLATION_UNIT_LOCAL; r…

74892f0

…esolves "unused" warning when compiling test_custom_type_casters.cpp

load_type fixes & follow-on cleanup

f5a1124

Strip ./ from source_file_line

c5c606a

Add new tests to CMakeLists.txt, disable PYBIND11_WERROR

d29c9d3

Replace C++17 syntax. Compiles with Debian clang 13 C++11 mode, but f…

3509807

…ails to link. Trying GitHub Actions anyway to see if there are any platforms that support https://en.cppreference.com/w/cpp/language/tu_local before C++20. Note that Debian clang 13 C++17 works locally.

Show C++ version along with ODR VIOLATION DETECTED message.

f8e1260

Add source_file_line_basename()

c474184

Introduce PYBIND11_TYPE_CASTER_ODR_GUARD_ON (but not set automatically).

c36911b

Minor cleanup.

156946e

Set PYBIND11_TYPE_CASTER_ODR_GUARD_ON automatically.

5d77dc3

Resolve clang-tidy error.

eb4df06

Compatibility with old compilers.

74010af

Fix off-by-one in source_file_line_basename()

98a56fc

Report PYBIND11_INTERNALS_ID & C++ Version from pytest_configure()

73f96ff

Restore use of PYBIND11_WERROR

f32f6d9

Move cpp_version_in_use() from cast.h to pybind11_tests.cpp

608aed1

define PYBIND11_DETAIL_ODR_GUARD_IMPL_THROW_DISABLED true in test_odr…

36d754d

…_guard_1,2.cpp

IWYU cleanup of detail/type_caster_odr_guard.h

5eba806

Replace throw err; to resolve clang-tidy error.

d146576

rwgk added 19 commits June 21, 2022 21:14

Add new header filename to CMakeLists.txt, test_files.py

d7ae4b5

Experiment: Try any C++17 compiler.

90c970a

Fix ifdef for pragma GCC diagnostic.

da965b0

type_caster_odr_guard_impl() cleanup

9e703e5

Move type_caster_odr_guard to type_caster_odr_guard.h

adde3b0

Rename test_odr_guard* to test_type_caster_odr_guard*

b2cb899

Remove comments that are (now) more distracting than helpful.

6657156

Mark tu_local_no_data_always_false operator bool as explicit (clang-t…

779f991

…idy). See also: https://stackoverflow.com/questions/39995573/when-can-i-use-explicit-operator-bool-without-a-cast

New PYBIND11_TYPE_CASTER_ODR_GUARD_STRICT option (current on by defau…

adffb5e

…lt).

Add test_type_caster_odr_registry_values(), test_type_caster_odr_viol…

cf63b9a

…ation_detected_counter()

Report UNEXPECTED: test_type_caster_odr_guard_2.cpp prevailed (but do…

1bfb95a

… not fail).

Apply clang-tidy suggestion.

12c80bc

Attempt to handle valgrind behavior.

1aa7742

Another attempt to handle valgrind behavior.

1634d1b

Yet another attempt to handle valgrind behavior.

44dba11

Trying a new direction: show compiler info & std for UNEXPECTED: type…

93bff3c

…_caster_odr_violation_detected_count() == 0

compiler_info MSVC fix. num_violations == 0 condition.

b3c2184

assert pybind11_tests.compiler_info is not None

dda1b41

try_builtin_file_line() just to probe what compilers support it.

92021f3

rwgk closed this Jun 24, 2022

rwgk deleted the odr_guard_sh__builtin_FILE_LINE_availability branch June 24, 2022 12:03

rwgk mentioned this pull request Feb 10, 2023

FWD pybind11 google/pybind11clif#4028

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[smart_holder] Simple experiment related to PR #4022 #4028

[smart_holder] Simple experiment related to PR #4022 #4028

rwgk commented Jun 24, 2022

rwgk commented Jun 24, 2022

[smart_holder] Simple experiment related to PR #4022 #4028

[smart_holder] Simple experiment related to PR #4022 #4028

Conversation

rwgk commented Jun 24, 2022

Description

Suggested changelog entry:

rwgk commented Jun 24, 2022