Skip to content

chore: add a couple of moves in pybind11.h #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 17, 2022
Merged

chore: add a couple of moves in pybind11.h #3941

merged 5 commits into from
May 17, 2022

Conversation

Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented May 14, 2022 •
edited
Loading

Description

  • Saw a few places where std::move could be safely used in pybind11.h along with some optimizations.

@Skylion007 Skylion007 requested review from rwgk and henryiii May 14, 2022 19:28
@Skylion007 Skylion007 changed the title chore: add a couple of moves to enum_base. chore: add a couple of moves in pybind11. May 14, 2022
@Skylion007 Skylion007 changed the title chore: add a couple of moves in pybind11. chore: add a couple of moves in pybind11.h May 14, 2022
@henryiii henryiii closed this May 16, 2022
@henryiii henryiii reopened this May 16, 2022
@Skylion007 Skylion007 merged commit a8b3ff3 into pybind:master May 17, 2022
@Skylion007 Skylion007 deleted the skylion007/enum_base_moves branch May 17, 2022 15:29
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label May 17, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 5, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii Awaiting requested review from henryiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @rwgk @henryiii