Skip to content

Don't trigger -Wunused-parameter in flagcheck.cpp. #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Don't trigger -Wunused-parameter in flagcheck.cpp. #2735

merged 1 commit into from
Dec 22, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 21, 2020

... by leaving the unused parameters anonymous.

(This can be checked e.g. by compiling python_example with -Wall
-Wextra.)

Suggested changelog entry:

* Don't trigger unused parameter warning in setup_helpers.py.

... by leaving the unused parameters anonymous.

(This can be checked e.g. by compiling python_example with -Wall
-Wextra.)
@henryiii henryiii added this to the v2.6.2 milestone Dec 22, 2020
@henryiii henryiii merged commit 6b4297f into pybind:master Dec 22, 2020
@henryiii
Copy link
Collaborator

Thanks!

@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Dec 22, 2020
@anntzer anntzer deleted the wunusedparameter branch December 22, 2020 06:40
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants