fix: match new extension discovery with changes to classic discovery #2640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
fix/so
branch
4 times, most recently
from
76ba919 to
298aa9b
Compare
Followup to pybind#2638 - this was fixed in 2.6.0, but only for classic Python
bstaletic
reviewed
Nov 4, 2020
bstaletic
approved these changes
Nov 5, 2020
rwgk
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Based on @bstaletic approval I support merging this PR into 2.6.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #2638 - this was fixed in 2.6.0, but only for classic Python
Suggested changelog entry:
None needed, too small.