-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add GHA and several test fixes #2321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -37,3 +37,4 @@ MANIFEST | |||
sosize-*.txt | |||
pybind11Config*.cmake | |||
pybind11Targets.cmake | |||
/*env* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the leading slash intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm assuming a virtual environment would be in the main directory or in a build directory (which should be already ignored)
@@ -203,10 +211,10 @@ foreach(target ${test_targets}) | |||
|
|||
# Always write the output file directly into the 'tests' directory (even on MSVC) | |||
if(NOT CMAKE_LIBRARY_OUTPUT_DIRECTORY) | |||
set_target_properties(${target} PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${testdir}) | |||
set_target_properties(${target} PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${testdir}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought cmake doesn't care about quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, without quotes spaces turn into separate arguments. All filename variables need to have quotes. We aren't testing with a space in the name of a directory, but I expect this would fail without quotes.
PyPy3 on macOS may have an error I didn't see before, due to not having numpy installed when I first ran the tests. I'll try adding the extra index recommended for PyPy wheels, maybe if we don't compile them, it will be both faster and work properly. Edit: This will only help Linux, not macOS, AFAICT. |
Adds requirements file too.
I've dropped NumPy on macOS + PyPy3 for now - looks like their issue (it's failing on |
This adds a basic GHA test suite. Features:
Test related fixes:
env
in the name is now ignored.Future plans:
-DDOWNLOAD_EIGEN
for CMake, add Eigen testing here.This should be "rebased & merged".