value_and_holder: uninit members #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix some uninitialized members in `value_and_holder` for some of the constructurs. Found with coverity in a downstream project.
ax3l
force-pushed
the
fix-valueHolderCastUninitMem
branch
from
8566dbf to
877fa66
Compare
|
Fine. |
wjakob
pushed a commit
that referenced
this pull request
Jun 11, 2019
fix some uninitialized members in `value_and_holder` for some of the constructurs. Found with coverity in a downstream project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some uninitialized members in
value_and_holderfor some of the constructors.value_and_holderhas two constructors that leave the class half-init and has several public methods that operate unchecked on those member vars (deref, etc.)Found with coverity in a downstream project.