Fix auto type deduction failures when var name is an existing type name #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems from the CI builds this still needs some work. |
|
Indeed. I thought I had it but i pushed premature and I've got a bit more churning on this to do. Since it might be a few days before I finish it I'll close this PR for now and reopen it after I test on the necessary platforms |
|
Feel free to leave it open, it doesn't hurt anything. Just ping me when it's ready and I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1381
nameis certainly the messiest and most pervasive of the bunch here. I'm happy to change any of the variable names as needed.While this does address the PGI type deduction issues, pybind11 still won't correctly build with PGI without #1428.