We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 9626483 commit 6d5d4e7Copy full SHA for 6d5d4e7
include/pybind11/stl_bind.h
@@ -191,7 +191,7 @@ void vector_modifiers(enable_if_t<is_copy_constructible<typename Vector::value_t
191
[](Vector &v) {
192
if (v.empty())
193
throw index_error();
194
- T t = v.back();
+ T t = std::move(v.back());
195
v.pop_back();
196
return t;
197
},
@@ -201,8 +201,8 @@ void vector_modifiers(enable_if_t<is_copy_constructible<typename Vector::value_t
201
cl.def("pop",
202
[wrap_i](Vector &v, DiffType i) {
203
i = wrap_i(i, v.size());
204
- T t = v[(SizeType) i];
205
- v.erase(v.begin() + i);
+ T t = std::move(v[(SizeType) i]);
+ v.erase(std::next(v.begin(), i));
206
207
208
arg("i"),
0 commit comments