fix: warning on latest AppleClang (#2522)

henryiii · web-flow · commit 3c7ef56bb651 · 2020-09-22T23:36:25.000+02:00
Fixed in #2510 but reintroduced on one line by #2126
diff --git a/include/pybind11/pybind11.h b/include/pybind11/pybind11.h
@@ -1489,7 +1489,7 @@ PYBIND11_NAMESPACE_BEGIN(detail)
 
 inline str enum_name(handle arg) {
     dict entries = arg.get_type().attr("__entries");
-    for (const auto &kv : entries) {
+    for (auto kv : entries) {
         if (handle(kv.second[int_(0)]).equal(arg))
             return pybind11::str(kv.first);
     }

Original file line number	Diff line number	Diff line change
`@@ -1489,7 +1489,7 @@ PYBIND11_NAMESPACE_BEGIN(detail)`
`1489`	`1489`
`1490`	`1490`	`inline str enum_name(handle arg) {`
`1491`	`1491`	`dict entries = arg.get_type().attr("__entries");`
`1492`		`- for (const auto &kv : entries) {`
	`1492`	`+ for (auto kv : entries) {`
`1493`	`1493`	`if (handle(kv.second[int_(0)]).equal(arg))`
`1494`	`1494`	`return pybind11::str(kv.first);`
`1495`	`1495`	`}`