Skip to content

Correting times in modelchain #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Correting times in modelchain #780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f530675
Assigning weather.index as self.times in modelchain if no times is gi…
matthiasLevy Sep 13, 2019
41d6a08
Using self.times instead of times in complete_irradiance for modelcha…
matthiasLevy Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pvlib/modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,8 @@ def complete_irradiance(self, times=None, weather=None):
self.weather = weather
if times is not None:
self.times = times
elif isinstance(weather.index, pd.DatetimeIndex):
self.times = weather.index
self.solar_position = self.location.get_solarposition(
self.times, method=self.solar_position_method)
icolumns = set(self.weather.columns)
Expand All @@ -803,7 +805,7 @@ def complete_irradiance(self, times=None, weather=None):

if {'ghi', 'dhi'} <= icolumns and 'dni' not in icolumns:
clearsky = self.location.get_clearsky(
times, solar_position=self.solar_position)
self.times, solar_position=self.solar_position)
self.weather.loc[:, 'dni'] = pvlib.irradiance.dni(
self.weather.loc[:, 'ghi'], self.weather.loc[:, 'dhi'],
self.solar_position.zenith,
Expand Down