-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ENH: Port PVsyst and Desoto parameter estimation from MATLAB #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 139 commits
Commits
Show all changes
148 commits
Select commit
Hold shift + click to select a range
c00d419
ENH: porting pvsyst and single diode param est
e3d8235
change function name from est_single_diode_params
mikofski 99d2f3f
use int indices, make docstring, test still fails
mikofski 55d1c0b
isolate iv fitting and parameter generation
mikofski 857d896
TST: schumaker test is passing! Yoohoo!
mikofski 0433136
TST: fix imports and path to test data
mikofski 1d418dd
fix Io test sortof, some stickler
mikofski 1a055e7
Merge branch 'master' into pvsyst_parameter_estimation
mikofski a1bdf55
fix tests, merge ivtools
mikofski b886dc8
fixing test_PVsyst_parameter_estimation
mikofski db58d39
include statsmodels and mpl in ci/conda-envs
mikofski f19f1de
stickler fixes, long lines, code tweaks
mikofski 2875438
rename update io and rsh tests so they run
mikofski 5252c8a
concise indexing in Schumaker QSpline
mikofski 38ee9b8
add test for numdiff
mikofski 90bb48b
move pvsyst parameter estimation tests
mikofski 4e27551
use maximum not max in estRsh
mikofski 2faed73
fudge tolerance for pvsyst_parameter_estimation for fun
mikofski aa1210b
restrict pvsyst estimation test to first 3000 points
mikofski b59227e
rename pvsyst parameter estimation tests folder
mikofski de85d38
move test_numdiff inside test_pvsyst_parameter_estimation.py
mikofski 82d452d
add requires_scipy to update_io_know_n tests
mikofski d6622f5
pycodestyle passing, rm xtra sp, fix indent
mikofski 18e2cb6
shuffle functions into different modules. Rename to fit_sdX_ pattern
cwhanse 9268fe8
fix import names
cwhanse 836a9b5
fix import in ivtools
mikofski edf872c
refactor deux: rm old files
mikofski 8b2d102
remove old pvsyst parma estimation tests
mikofski d9abba1
stickler fixes
mikofski 1508b1d
Merge branch 'master' into pvsyst_parameter_estimation
mikofski 152dd24
Merge branch 'master' into pvsyst_parameter_estimation
mikofski 9b56560
using lambertw requires scipy in tests
mikofski a7dfe45
align with scipy.intepolate pattern
cwhanse 8d67a97
refactor fit_sde_cocontent, change argument order
cwhanse 780db42
stickler
cwhanse 5207c60
fix argument order in fit_pvsyst_sandia
cwhanse b5270da
fix rectify function, add test
cwhanse 47e4465
stickler
cwhanse 1e1496c
corrections, add rcond=None
cwhanse 98bcc25
more corrections
cwhanse a9c908d
undo change in rs, rsh order
cwhanse b2cbb11
fix test for rectify_iv_curve, use np.expm1
cwhanse 2e973fe
exclude curve #2540
cwhanse 383a1f8
fix expected outcome for test_rectify_
cwhanse e22942f
messed up csv
cwhanse 1484e39
exclude curve #2540
cwhanse 7f90f26
correct rounding for test_rectify_
cwhanse 9c00ac8
move exclude to line 2540 was on 2536
cwhanse d52dade
create exclude mask for individual curves
cwhanse f934275
use umask
cwhanse ed378ac
helper functions, some streamlining
cwhanse 41ca062
rename _update_io_known_n
cwhanse de1b493
docstring improvements
cwhanse e202506
split _calc_theta_phi_exact, overhaul tests
cwhanse d3baff3
remove unused lines
cwhanse 08a5627
stickler
cwhanse a8059cb
remove test_ivtools.py
cwhanse 9fc68b5
renaming, update api.rst
cwhanse e1544a3
update name
cwhanse 0626805
improve _update_rsh_fixed_pt
cwhanse fdc0e66
fix typo
cwhanse 8465bc0
fix error
cwhanse 82669f4
correct convergence in _update_rsh_fixed_pt
cwhanse 027f2ee
flake8
cwhanse 5e7cc77
docstring for fit_sdm
cwhanse 6ae5927
docstring for fit_sdm
cwhanse 0a6fcab
docstring for fit_sdm
cwhanse 317b92c
docstring for fit_sdm
cwhanse 385a14b
docstring for fit_sde, utility
cwhanse 0f7fab2
update api.rst
cwhanse 11c98e5
add helper to deal with numpy<1.14
cwhanse 291e086
fix workaround for numpy version
cwhanse 4e80ea1
rename modules and functions, move tests to ivtools/test
cwhanse a9a4b7a
merge master, fix conflict
cwhanse 0450815
fix merge conflicts, contains duplicated files
cwhanse d547521
move tests from ivtools/test to pvlib/tests/ivtools
cwhanse e98652e
remove old test folder
cwhanse f5351a9
remove old pvlib/test folder
cwhanse 6a413d2
name correction, remove old test files
cwhanse 6fe3c33
fix test, move test_fit_sde_cocontent into test_sde
cwhanse 9f2e474
move test_schumaker_qspline to test_utility
cwhanse 104052b
docstring work
cwhanse 4392f70
resolve conflict
cwhanse ab31257
docstring work
cwhanse 6c7c071
test corrections
cwhanse 8d1b8b0
fix order in parametrize
cwhanse 5e18986
one comma
cwhanse f08e1f6
corrections
cwhanse ea6a157
remove old files, update api.rst
cwhanse f7911fc
update names in ivtools\__init__.py
cwhanse 488726d
docstring work, rename outputs from fit_pvsyst_sandia to be consisten…
cwhanse 949aad7
docstring work, use cells_in_series throughout
cwhanse 499ff7b
docstring work, use mu_gamma instead of mugamma
cwhanse a1ddcf9
missed one
cwhanse 09127c6
sort of Rs vs R_s vs R_s_ref
cwhanse 27e4200
refactor to prepare for adding desoto, cec estimation; remove logging
cwhanse 0e4485b
merge
cwhanse f5b7ee4
add fit_desoto_sandia
cwhanse 182f95b
correct argument order, lint
cwhanse 987257d
change to pvlib-consistent key names
cwhanse 37ee5d9
add test for fit_desoto_sandia
cwhanse d4c1950
corrections
cwhanse a2423e5
more corrections
cwhanse 59f69be
use canonical order iph, io, rs, rsh, n
cwhanse 15d4d6b
convert update_rsh test, move to test_sdm.py
cwhanse e168ead
fix update_rsh tests, improve function
cwhanse e605483
remove old update_rsh test file
cwhanse a33fed7
convert tests for _update_io
cwhanse 9f8a0e1
remove old tests for _update_io
cwhanse 64a51c1
convert tests for calc_theta_phi
cwhanse 89d6442
remove old test for calc_theta
cwhanse 6c45599
take care of float div by 0 test failures
cwhanse 579b80d
move sde functions to canonical argument order
cwhanse d5ace89
fix bugs
cwhanse 88c8995
more raid for bugs
cwhanse cad323b
die bugs die
cwhanse 20b7e6d
maintain order of variables in the text file
cwhanse 64a9fe5
test repair
cwhanse d44dbe7
minor editing
cwhanse 83a2c30
pin pysam version to 1.2.1
cwhanse d0aed99
pysam to current version, patch over numpy 1.14 change
cwhanse 22e8b7e
module docstring
cwhanse bb2af7e
Merge branch 'pvsyst_parameter_estimation' of https://github.com/miko…
cwhanse 0f9896a
Merge remote-tracking branch 'upstream/master' into pvsyst_parameter_…
cwhanse d3a52e3
remove ivtools.py
cwhanse adb8290
separate sam_estimate_failure into its own function
cwhanse 5bd14c7
Merge branch 'master' of https://github.com/pvlib/pvlib-python into p…
cwhanse 157c2ab
Merge branch 'master' of https://github.com/pvlib/pvlib-python into p…
cwhanse a5d5ffa
fix stickler
cwhanse f46287e
'mispelling'
cwhanse c8b4b00
fix error in _calc_I0
cwhanse eea759b
more fixing of that error
cwhanse fa8d8a6
improvements from review
cwhanse 944c16b
another fix for mistake in _calc_I0
cwhanse eb8d986
docstring edits
cwhanse 8cc8249
improve coverage
cwhanse fce9b04
tpo
cwhanse b548f63
use the correct error Class
cwhanse df7520e
improvements from review
cwhanse cad96ef
changes from review: helper functions for test, _numdiff and _schum p…
cwhanse 4831cfd
whatsnew
cwhanse 83308a3
Merge branch 'master' of https://github.com/pvlib/pvlib-python into p…
cwhanse a1dc575
add renamed and moved data files
cwhanse ab4f99b
use pathlib.Path.open()
cwhanse cad3949
duh
cwhanse 6866922
add return, doing three things at once = poor quality
cwhanse e9dba7d
add statsmodels for py38, fix dict declarations
cwhanse 0c41ed2
()
cwhanse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
4.50204,0,nan,nan | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why |
||
4.50204,0.00175191,nan,nan | ||
4.49472,0.911824,-0.010145246,-72.80843849 | ||
4.48884,1.97675,-0.005751568,-140.8055651 | ||
4.48164,3.01497,-0.00822002,-140.1386978 | ||
4.47138,4.06362,-0.010291349,-141.8386901 | ||
4.45985,4.97604,-0.020908086,-142.9181672 | ||
4.42574,6.14163,-0.02566405,-147.3187136 | ||
4.40784,7.19992,-0.008920042,-149.6628732 | ||
4.40468,8.21476,-0.001515876,-136.050251 | ||
4.4022,9.26073,-0.002817116,-139.4178379 | ||
4.39879,10.1839,-0.00478659,-140.5653076 | ||
4.39142,11.3523,-0.007611589,-138.4742825 | ||
4.38281,12.37,-0.007810157,-145.6159998 | ||
4.37405,13.3071,-0.013857843,-102.7212079 | ||
4.34333,14.4719,-0.037140714,13.04970087 | ||
4.33309,14.6878,-0.062620853,-12.84849357 | ||
4.31909,14.8763,-0.082851406,-4.070296488 | ||
4.30458,15.0365,-0.101186357,-3.428773583 | ||
4.28668,15.196,-0.121133891,-3.213924862 | ||
4.26735,15.3443,-0.143312447,-3.229938163 | ||
4.24065,15.5133,-0.167457277,-3.30362981 | ||
4.21216,15.6751,-0.188289275,-3.327817958 | ||
4.1795,15.8367,-0.21541711,-3.230612068 | ||
4.14325,15.9947,-0.245091444,-3.181351952 | ||
4.1009,16.1568,-0.274299817,-3.134890208 | ||
4.05487,16.3159,-0.31074685,-3.089888279 | ||
4.00167,16.4751,-0.354284766,-3.031435265 | ||
3.94243,16.6335,-0.393829059,-2.994236863 | ||
3.87562,16.7937,-0.445913377,-2.935654664 | ||
3.79949,16.9536,-0.50254815,-2.885218025 | ||
3.71645,17.1111,-0.551075913,-2.814862224 | ||
3.62355,17.2719,-0.608316741,-2.615705304 | ||
3.52115,17.4311,-0.682639753,-2.572784269 | ||
3.42088,17.5711,-0.741307014,-2.477959642 | ||
3.28754,17.7437,-0.813793394,-2.480261198 | ||
3.15101,17.9029,-0.904379859,-2.409711013 | ||
3.00189,18.0603,-0.978731915,-2.218176784 | ||
2.84641,18.2143,-1.047363595,-2.109147866 | ||
2.66833,18.3761,-1.18506695,-1.993365364 | ||
2.46753,18.5371,-1.226714832,-1.853529632 | ||
2.27866,18.6932,-1.273461155,-1.677887728 | ||
2.06416,18.8505,-1.437454627,-1.500633771 | ||
1.82713,19.01,-1.482381209,-1.296712301 | ||
1.59636,19.1653,-1.557319102,-1.140972405 | ||
1.35999,19.3101,-1.662342068,-0.935441311 | ||
1.07257,19.4805,-1.738263164,-0.785061206 | ||
0.791388,19.6375,-1.833577303,-0.555627147 | ||
0.49834,19.7938,-1.923310649,-0.299657361 | ||
0.224364,19.9335,-2.22468188,-0.100196553 | ||
0.0264409,20.0322,nan,nan | ||
0,20.0528,nan,nan |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.