Skip to content

use hrrr surface temp, wind. other refactoring #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2018

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Nov 3, 2018

  • Closes HRRR weathermodel 'temp_air' calculation wrong #604
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren wholmgren added this to the 0.6.1 milestone Nov 3, 2018
@wholmgren
Copy link
Member Author

Tests pass. I suggest that we not worry about the untested line that handles and exception. If it works, great, we get a more informative message. If it fails, well, it was going to fail anyways.

I'll merge soon unless I hear objections or a review comes in. Keep in mind that a lot this code might change in the next 6 months.

@cwhanse
Copy link
Member

cwhanse commented Nov 26, 2018

LGTM

@wholmgren wholmgren merged commit f8edab9 into pvlib:master Nov 26, 2018
@wholmgren wholmgren deleted the hrrrtemp branch November 26, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants