Skip to content

set default module and inverter_parameters to empty dict #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/sphinx/source/whatsnew/v0.4.4.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ Enhancements
improvements by Ineichen and Perez to extend range of air mass (:issue:`278`)


API Changes
~~~~~~~~~~~

* Change PVSystem default module_parameters and inverter_parameters to
empty dict. Code that relied on these attributes being None or raising
a TypeError will need to be updated. (issue:`294`)


Documentation
~~~~~~~~~~~~~

Expand Down
10 changes: 8 additions & 2 deletions pvlib/pvsystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,19 @@ def __init__(self,

# could tie these together with @property
self.module = module
self.module_parameters = module_parameters
if module_parameters is None:
self.module_parameters = {}
else:
self.module_parameters = module_parameters

self.modules_per_string = modules_per_string
self.strings_per_inverter = strings_per_inverter

self.inverter = inverter
self.inverter_parameters = inverter_parameters
if inverter_parameters is None:
self.inverter_parameters = {}
else:
self.inverter_parameters = inverter_parameters

self.racking_model = racking_model

Expand Down
3 changes: 3 additions & 0 deletions pvlib/test/test_pvsystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,9 @@ def test_snlinverter_Pnt_micro(sam_data):

def test_PVSystem_creation():
pv_system = pvsystem.PVSystem(module='blah', inverter='blarg')
# ensure that parameter attributes are dict-like. GH 294
pv_system.module_parameters['pdc0'] = 1
pv_system.inverter_parameters['Paco'] = 1


def test_PVSystem_get_aoi():
Expand Down