Change server parameter to url in get_cams #2463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echedey-ls
approved these changes
May 26, 2025
Comment on lines
9
to
11
| * The ``server`` parameter in :py:func:`~pvlib.iotools.get_cams` has been renamed | ||
| to ``url`` to be consistent with the other iotoools. | ||
| :pull:`2463` |
There was a problem hiding this comment.
Should be moved to the section down below, "Deprecations" (IMO)
There was a problem hiding this comment.
I agree. It's first when it is completely removed that it should be listed in the "Breaking changes" section.
cwhanse
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR renames the parameter
serveringet_camstourlto be consistent with the other iotools.