Skip to content

Issue244: Fix for isinstance str in python 3. #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lukewitmer
Copy link

location timezone support for python3 newstr and unicode args

@wholmgren
Copy link
Member

I think one problem is that basestring doesn't exist in Python 3. It looks like you can import six and use string_types as described here:

http://stackoverflow.com/questions/11301138/how-to-check-if-variable-is-string-with-python-2-and-3-compatibility

Might be some unrelated pandas 0.19 as well as forecast module problems, too.

@lukewitmer
Copy link
Author

Interesting. Good point on basestring not being in python 3. I'll take a more detailed look at it tonight or tomorrow, as well as actually testing against python3 (instead of in python2 with future imports which is what I tested before submitting the PR).

@wholmgren
Copy link
Member

I reran the travis tests for this PR now that #247 is merged. It looks like the only issue here is the basestring issue on Python 3 and hopefully the fix is as simple as advertised. I'll wait to release 0.4.1 if you can try that in the next 24 hours. Please also add a note and your name or username to the whatsnew file.

@wholmgren wholmgren added this to the 0.4.2 milestone Oct 21, 2016
@wholmgren
Copy link
Member

@lukewitmer are you still interested in pursuing this fix or can we close it and #244? I'm trying to clean up some issues and PRs. I can also take a quick attempt at it if you check the "allow edits from maintainers" box at the bottom of the right most column. Thanks!

@wholmgren wholmgren modified the milestones: 0.4.3, 0.4.2 Dec 7, 2016
@wholmgren wholmgren modified the milestones: 0.4.4, 0.4.3 Dec 28, 2016
@wholmgren wholmgren modified the milestones: 0.4.5, 0.4.4 Feb 15, 2017
@wholmgren
Copy link
Member

@lukewitmer feel free to reopen if you want to finish this.

@wholmgren wholmgren closed this Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants