Skip to content

[WIP] irradiance.py updates: glossary term links and units #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Nov 27, 2024

Updating the units to superscript and linking key terms to their glossary page definitions.
Follow up PR(s): add some of these key terms into the glossary, enhance existing glossary term definitions (units and explanation)
Note: we can now view definition tooltips by hovering the cursor over the linked glossary term (context: #2290)

@RDaxini RDaxini added this to the v0.11.2 milestone Nov 27, 2024
@RDaxini
Copy link
Contributor Author

RDaxini commented Dec 9, 2024

I could modify the scope of this PR if we want to see some of the changes implemented in 11.2. I don't think these changes are urgent though so I'm also happy to keep working on it and merge the completed version in 11.3. Not sure what reviewers would prefer though--- on second thoughts many small revisions covering the entire irradiance.py might be a pain to review. Thoughts @kandersolar @AdamRJensen @cwhanse ?

@RDaxini RDaxini modified the milestones: v0.11.2, v0.11.3 Dec 13, 2024
@RDaxini RDaxini mentioned this pull request Feb 25, 2025
8 tasks
@kandersolar kandersolar modified the milestones: v0.11.3, v0.11.4 Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants