-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove deprecated pvsystem.sapm_spectral_loss
#2244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@RDaxini can you please also remove the entry in |
In a similar sense to my own comment, to avoid links warnings with a Sphinx builder that checks them (linkchecker, with the Option
Otherwise, LGTM :D |
Co-authored-by: Kevin Anderson <[email protected]>
Co-Authored-By: Echedey Luis <[email protected]>
…i/pvlib-python into remove_sapm_spectral_loss
@RDaxini can you review the changes made to |
Good catch @echedey-ls! I agree, the wrong one was removed. To avoid the clutter of a new PR to fix such a small thing, I'll plan to just fix that in the release finalization PR. |
* whatsnew cleanup * add missing contributors * fix minor docs error from #2244 * misc cleanup * rename 0.11.3 to 0.12.0 * add missed edits to contributing guide for new tests location * remove missed `fail_on_pvlib_version` decorator for get_am15g * remove duplicated entries * a few more rst fixes * Update docs/sphinx/source/whatsnew/v0.12.0.rst Co-authored-by: RDaxini <[email protected]> --------- Co-authored-by: RDaxini <[email protected]>
pvsystem.sapm_spectral_loss
not removed #2243addedremoveddocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).Wait for 12.0?
remote-data
) and Milestone are assigned to the Pull Request and linked Issue.I am not super familiar with deprecations so please correct me if I have misunderstood something here or even missed an existing PR for this...