improvements to irradiance module, increase min requirements #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wholmgren
force-pushed
the
irradiancerefactor
branch
from
7a56ec3 to
35b5a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of improvements to the irradiance module:
It also increases the minimum pandas and numpy requirements to 0.14.0 and 1.9.0, respectively. This is necessary to avoid some ugly hacks for supporting scalar inputs in a few functions. These releases are around 2 years old, so I don't anticipate that this will be a problem for any users.
It also resolves a problem in which pvlib's minimum requirements were not being properly tested due to Continuum's bad practice of bundling scipy with pandas.