You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
Pull request is nearly complete and ready for detailed review.
Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.
While running the benchmark I found that minimum scipy version in asv.conf.json was throwing error on incrementing It to 1.5.0 from 1.4.0 runs it. On further Investigation for 1.4.0 requires numpy>=1.17.3 which was greater than minimum.
but for 1.5.0 numpy requirement is lesser than minimum required
The error is thrown when I tested it using environment built by asv
On further Investigation for 1.4.0 requires numpy>=1.17.3
The screenshot says numpy>=1.17.3 is required when using Python 3.8, but we use scipy==1.4.0 in the Python 3.7 environment. The screenshot says that only numpy>=1.14.5 is required for python 3.7. We use numpy==1.16.5 for that environment, so I don't see any problem with the scipy/numpy versions. Additionally, that environment builds successfully in our CI: https://github.com/pvlib/pvlib-python/actions/runs/4455677669/jobs/7825630747#step:5:34
So I don't see why this PR is necessary. @Lakshyadevelops what do you think?
Ok, I see numpy,scipy is not the issue.
Running using asv dev in py3.7 does not throw error. But asv run still throws could not resolve scipy 1.4.0 . conda actually does not have scipy 1.4.0 conda-forge has 1.4.0.
I tried to run with 1.4.1 and it runs.
I tried to modify asv.conf.json to re-order package order from condaforge->defaults but none worked.
Is it a windows issue of conda-forge not able to get package?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.While running the benchmark I found that minimum scipy version in asv.conf.json was throwing error on incrementing It to 1.5.0 from 1.4.0 runs it. On further Investigation for 1.4.0 requires numpy>=1.17.3 which was greater than minimum.
but for 1.5.0 numpy requirement is lesser than minimum required
The error is thrown when I tested it using environment built by asv