-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add map_variables parameter to read_tmy3 function #1623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
0e60277
Added map_variables param in read_tmy3 func
a8977fa
solved failing tests
054dd35
solved failing tests
3c7f7f6
solving stickerly test fail
dc6399d
solving stickerly test fail
773b94e
solving stickerly test fail
df97faf
added variable_map
2eee8ce
resolving formatting issues
7a86c55
Update pvlib/iotools/tmy.py
ooprathamm 7013739
Update pvlib/iotools/tmy.py
ooprathamm 16b3986
Update pvlib/iotools/tmy.py
ooprathamm 5210407
Update pvlib/iotools/tmy.py
ooprathamm 68b54fe
Added tests to map_variables and check depreciation warning
2ccae9e
resolving formatting issues
1ee7ff0
resolving formatting issues
98e53b3
Adding more test cases
8e5c4d7
Merge branch 'pvlib:main' into main
ooprathamm 96a30a6
updated VARIABLE_MAP
9a69f12
updates DOIs in tmy.py
850a798
Merge branch 'pvlib:main' into main
ooprathamm 1e86046
Final changes as requested
0244732
Fix stickler
AdamRJensen bccaf02
Update variables_style_rules.csv
AdamRJensen c4e4417
Add missing map_variables=False
AdamRJensen b91408a
Add whatsnew deprecation entry
AdamRJensen 94383e9
Apply suggestions from code review
AdamRJensen 2d02f4d
Merge branch 'main' into main
AdamRJensen c6ebd9e
Add separate if statement for warning
AdamRJensen 616cc76
removed wrong whatsnew entry
cd9cc86
Update pvlib/tests/iotools/test_tmy.py
ooprathamm da591f5
Update warning messages according to table
AdamRJensen 13b8782
Merge remote-tracking branch 'upstream/main' into pr/1623
AdamRJensen 8f9c788
Update whatsnew
AdamRJensen 5661f71
Set recolumn=None
AdamRJensen a3e2016
Update tests
AdamRJensen d0d1644
Update pvlib/iotools/tmy.py
AdamRJensen b080c76
Update pvlib/iotools/tmy.py
AdamRJensen da131ad
Update docs/sphinx/source/whatsnew/v0.9.6.rst
AdamRJensen 828b994
Implement updated error message logic from kansersolar
AdamRJensen 737f5d6
Merge branch 'main' of https://github.com/ooprathamm/pvlib-python int…
AdamRJensen 1f31390
Clean up deprecation warnings
AdamRJensen b720399
Merge branch 'main' into main
AdamRJensen 98e7891
Fix clearsky.rst
AdamRJensen d0c5309
Merge branch 'main' of https://github.com/ooprathamm/pvlib-python int…
AdamRJensen 24e90d7
Update aod variable mapping
AdamRJensen b4bf004
Fix stickler
AdamRJensen 143f9ac
Update tmy3 variables names in field,description table
AdamRJensen 5d2ef3a
Update table
AdamRJensen fe2f343
More table stuff
AdamRJensen 35d2d54
Table stuff galore
AdamRJensen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.