Skip to content

Remove xfail marker from get_psm3_5min test #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

kandersolar
Copy link
Member

  • Closes NSRDB Surface Albedo values are changed for 2019 files #1091
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Undo #1097 now that the API's data has been corrected. Our original data file is correct, so no need for any other changes.

@wholmgren wholmgren added this to the 0.8.1 milestone Dec 12, 2020
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for digging into this @kanderso-nrel

@wholmgren wholmgren merged commit 0d0aab4 into pvlib:master Dec 12, 2020
@kandersolar kandersolar deleted the psm3_albedo branch December 13, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSRDB Surface Albedo values are changed for 2019 files
2 participants