Skip to content

pvwatts_ac returns values less than 0 #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wholmgren opened this issue Aug 21, 2018 · 1 comment · Fixed by #542
Closed

pvwatts_ac returns values less than 0 #541

wholmgren opened this issue Aug 21, 2018 · 1 comment · Fixed by #542
Labels
Milestone

Comments

@wholmgren
Copy link
Member

Describe the bug
The pvwatts ac power model is proportional to the quantity eta as defined by

zeta = pdc / pdc0
eta = -0.0162*zeta - 0.0059/zeta + 0.9858

eta is negative for eta < 0.006 or so. While ac power less than 0 is not unphysical, I don't think the intention was for the PVWatts AC model to yield these values. I don't see any explicit reference to this in the PVWatts manual.

To Reproduce
Run pvwatts_ac with a pdc value that is less than 0.006 of pdc0.

Expected behavior
0 should be returned for these values instead.

Screenshots

download-5

Versions:

  • pvlib.__version__: '0.5.2+35.g0aa4d2e'
  • pandas.__version__: n/a
  • python: n/a
@cwhanse
Copy link
Member

cwhanse commented Aug 21, 2018

I concur with your recommended change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants