Skip to content

Typo "modelt" in function signature pvlib.irradiance.perez #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mangecoeur opened this issue Jun 23, 2016 · 2 comments
Closed

Typo "modelt" in function signature pvlib.irradiance.perez #196

mangecoeur opened this issue Jun 23, 2016 · 2 comments
Labels
api bug
Milestone
0.4.0

Comments

@mangecoeur
Copy link
Contributor

mangecoeur commented Jun 23, 2016 •
edited
Loading

The function uses modelt instead of model:

pvlib.irradiance.perez(surface_tilt, surface_azimuth, dhi, dni, dni_extra, solar_zenith, solar_azimuth, airmass, modelt='allsitescomposite1990')

should be

pvlib.irradiance.perez(surface_tilt, surface_azimuth, dhi, dni, dni_extra, solar_zenith, solar_azimuth, airmass, model='allsitescomposite1990')

http://pvlib-python.readthedocs.io/en/latest/modules.html#pvlib.irradiance.perez
@wholmgren
Copy link
Member

Yes, I've noticed that before too. Feel free to submit a pull request.

@wholmgren wholmgren added this to the 0.4.0 milestone Jun 23, 2016
@mangecoeur
Copy link
Contributor Author

PR sent

wholmgren pushed a commit that referenced this issue Jun 27, 2016
@mangecoeur @wholmgren
Correct spelling modelt to model #196 (#203)
155ac77 
* Correct spelling modelt to model #196

* Added changes to Whatsnew file
@wholmgren wholmgren mentioned this issue Jun 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api bug
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@mangecoeur @wholmgren