Skip to content

Update development instructions #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2021
Merged

Conversation

thomashoneyman
Copy link
Member

@thomashoneyman thomashoneyman commented May 28, 2021

Closes #202, #196, #183. Confirmed that on a fresh clone of Try PureScript, following these instructions exactly, I can run the client against a local server or the production Try PureScript server with no additional tools or steps. cc: @milesfrain.

@thomashoneyman thomashoneyman requested review from JordanMartinez and hdgarrood and removed request for JordanMartinez May 28, 2021 21:11
@JordanMartinez
Copy link
Contributor

I did the following:

  1. I did a fresh clone
  2. Rebased this PR on top of master, which now includes Provide externs to rebuildModule #224
  3. Followed the instructions exactly
  4. Everything compiled, but things still don't work on my side

trypurescript-still-broken

Looking at the developer tools, the 500 error had this message:

Error: ELOOP: too many symbolic links encountered, stat '/home/jordan/Programming/Projects/trypurescript/client/public/js/output/Data.Foldable/index.js'

Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fact that Thomas got it to work shows that there might be a problem with my environment. I'm not sure what that may be. Should we merge this anyway since it worked for at least one person?

@thomashoneyman
Copy link
Member Author

@JordanMartinez I’m on MacOS using zsh; perhaps there’s a difference between operating systems or shells?

@thomashoneyman
Copy link
Member Author

I’m going to merge as this at least gets the instructions right in general, but ideally we get it working across systems.

@thomashoneyman thomashoneyman merged commit eaf51ec into master May 29, 2021
@thomashoneyman thomashoneyman deleted the update-dev-instructions branch May 29, 2021 03:56
@JordanMartinez
Copy link
Contributor

I’m going to merge as this at least gets the instructions right in general, but ideally we get it working across systems.

Sounds good to me! Thanks for all your work on getting this updated to v0.14.x!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants