Update trypurescript deps to match purescript repo versions #223
Conversation
trypurescript.cabal
Outdated
| filepath -any, | ||
| Glob -any, | ||
| scotty -any, | ||
| build-depends: base ==4.14.1.0, |
There was a problem hiding this comment.
Can we leave the bounds as -any here, please? All of these dependencies are already sufficiently nailed down by purescript itself. The only ones where I think we should keep the bounds are scotty and warp.
There was a problem hiding this comment.
Meaning, if a dependency version was listed as -any, keep it as that? Since your comment here was made on the base line, I'm getting conflicting information in this comment.
There was a problem hiding this comment.
Yeah sorry, I think base can be left alone too.
There was a problem hiding this comment.
I've force-pushed some changes to reset earlier work. What needs to change now?
stack.yaml
Outdated
| - github: purescript/purescript | ||
| commit: 7ecc42669c69682996f2196ba2eef6c4ca827348 | ||
| commit: 0d570f6e3828fc1a93c7c20252bccb04b7d2b0f6 |
There was a problem hiding this comment.
Can we switch back to using a released version of purescript now please?
There was a problem hiding this comment.
Yeah. One downside of this is that purescript depends on purescript-ast, which is going to be merged into purescript-cst. So, we'll need to update this again to drop purescript-ast once v0.14.2 is released.
There was a problem hiding this comment.
That's fine, we'll need to update this file at that point anyway.
- I'm following what is shown in purescript.cabal, so I'm not 100% sure this is entirely correct (e.g. removal of `network`)
- all except http-types, which isn't used in purescript
| flags: | ||
| aeson-pretty: | ||
| lib-only: true | ||
| these: | ||
| assoc: false | ||
| quickcheck: false |
There was a problem hiding this comment.
Is it possible to keep this in? It lets us avoid depending on quickcheck.
There was a problem hiding this comment.
It seems like it's an invalid flag. If I run stack build with that included, I get this error:
$ stack build
Invalid flag specification:
- Package 'these' does not define the following flags (specified in stack.yaml):
quickcheck
- Flags defined by package 'these':
these:assoc
Note: PureScript's stack.yaml file doesn't have that flag either.
There was a problem hiding this comment.
Oh right ok sorry, I didn’t realise it had been removed.
trypurescript.cabal
Outdated
| data-default -any, | ||
| directory -any, | ||
| filepath -any, | ||
| Glob -any, | ||
| scotty -any, | ||
| scotty ==0.12, | ||
| purescript, | ||
| purescript-cst, | ||
| containers -any, | ||
| http-types >= 0.8.5, |
There was a problem hiding this comment.
@hdgarrood Before I merge this, should http-types be updated to -any or to the lts-17.6 package set's version, which is 0.12.3?
And is it correct that -any will use whichever dependencies work with purescript and the other versions dependencies? I'm not familiar with this syntax unfortunately.
There was a problem hiding this comment.
Thinking about this a little more I think we might as well use -any for all of the dependencies here. This project is only ever going to be built by stack, and the stack.yaml file already pins everything down to a specific version, so additionally specifying versions here doesn’t really add anything.
It’s more important to provide accurate version bounds when you’re making a library which other people are depending on - this part of the cabal file does the same job as the dependencies part of a bower.json or package.json file in a JS library. But that’s not what we are doing here so it doesn’t really matter.
No description provided.