Skip to content

Implement encode in PureScript #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2020
Merged

Implement encode in PureScript #186

merged 1 commit into from
Aug 1, 2020

Conversation

maxdeviant
Copy link
Contributor

Unless I'm missing some crucial context, there doesn't seem to be a reason why we need to use the FFI for encode.

Resolves #185.

thomashoneyman
thomashoneyman approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why it was implemented via the FFI. Unless another maintainer thinks this shouldn't go through, I'm happy to merge this.

@thomashoneyman thomashoneyman merged commit a0c4de2 into purescript:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdgarrood hdgarrood hdgarrood approved these changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is this pure function foreign?
3 participants
@maxdeviant @hdgarrood @thomashoneyman