Make unfoldr stack-safe. #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| go Nothing = Nil | ||
| go (Just (Tuple a b)) = Cons a (go (f b)) | ||
| go source memo = case f source of | ||
| Nothing -> memo |
There was a problem hiding this comment.
Doesn't this need to be reversed?
|
Yes, I just noticed that too! I'll work on a fix. |
|
I've added the call to I wasn't sure whether the right thing to do was reverse the whole thing at the end (which is what I chose), or try to add each individual item to the end as we go. If the latter is better, I'd be happy to do that instead. |
|
I took a look at |
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unfoldableListimplementation wasn't tail-recursive, which caused the problems described here:hdgarrood/purescript-sequences#20
This pull request changes
unfoldrso that it is tail-recursive. The provided test fails without the change.